Security Hub - get_findings and batch_import_findings #8518
+373
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8518 +/- ##
==========================================
- Coverage 92.63% 92.62% -0.01%
==========================================
Files 1229 1234 +5
Lines 106394 106480 +86
==========================================
+ Hits 98553 98632 +79
- Misses 7841 7848 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Singha22
changed the title
bblommers
requested changes
Feb 2, 2025
| op="GetFindings", msg="MaxResults must be a number greater than 0" | ||
| ) | ||
|
|
||
| paginator = Paginator( |
There was a problem hiding this comment.
It looks like we can just use the @paginate-decorator on the method here, that should simplify the implementation a bit.
Please see the docs here: https://docs.getmoto.org/en/latest/docs/contributing/development_tips/utilities.html#paginator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8493
get_findingscontains code for only these 2 parameters out of the 4 parameters